Skip to content

Fix cppcheck warnings, typos, style issues (backport #1227)#1230

Merged
iche033 merged 1 commit intomainfrom
mergify/bp/main/pr-1227
Jan 29, 2026
Merged

Fix cppcheck warnings, typos, style issues (backport #1227)#1230
iche033 merged 1 commit intomainfrom
mergify/bp/main/pr-1227

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jan 28, 2026

🦟 Bug fix

Fixes #

Summary

I'm running CppCheck with compile_commands.json file which generated by cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON (and manual path tweak to run scan on host), not make cppcheck

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #1227 done by Mergify.

Reducing CppCheck report size, frequent warnings:
* missing override (CI-clang seems also affected by this)
* different argument name
* variable scope can be reduced
* Ogre or containers in standard library most of times use size_t, better to use
* Fix typos
* In general tried to follow the rule from c++ core guidelines https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c128-virtual-functions-should-specify-exactly-one-of-virtual-override-or-final (but changing it in all code could make PR much bigger)

Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com>
(cherry picked from commit a395a95)
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jan 29, 2026
@iche033 iche033 merged commit 8a24802 into main Jan 29, 2026
13 of 14 checks passed
@iche033 iche033 deleted the mergify/bp/main/pr-1227 branch January 29, 2026 17:15
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants